add optional redis for backend storage by olamilekan000 · Pull Request #489 · kbind-dev/kbind

olamilekan000 · 2026-03-04T13:43:10Z

Summary

change adds an optional redis storage for the backend

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes 424
Fixes 488

Release Notes

Added optional Redis for backend storage

mjudeikis

Quick skim, but I would imagine something like this:

session/
  provider.go # defines interface only and small `New` method maybe, or even skip taht and do all in cmd.
  redis/redis.go # implements ^
  memory/memory.go  # implements ^

and types are not even needed. Basically - no flags provided - provider is memory, if redis-smth-smth is provided - its redis. If 2 provider flags (not yet supported) is there - validate in cmd and fail.

to the point where every provider could have its own AddFlags(), Validate(), etc methods and be loaded into main cmd flag-set

mjudeikis

You know that adding this is calling for e2e test? :D could be follow-up but if we add this ,we will need redis in tests

olamilekan000 · 2026-03-09T15:18:10Z

You know that adding this is calling for e2e test? :D could be follow-up but if we add this ,we will need redis in tests

I think we can use test-containers

mjudeikis · 2026-03-30T06:43:51Z

@xrstf for your approval :)

xrstf · 2026-04-01T09:12:07Z

/approve

cnvergence · 2026-04-01T09:29:24Z

@olamilekan000 let's resolve the conflict and merge it 🎉

olamilekan000 requested a review from a team as a code owner March 4, 2026 13:43

olamilekan000 force-pushed the add-redis-storage-for-backend branch from 480440f to c665d0d Compare March 4, 2026 13:46

mjudeikis reviewed Mar 4, 2026

View reviewed changes

Comment thread backend/session/store.go Outdated

mjudeikis reviewed Mar 4, 2026

View reviewed changes

Comment thread backend/session/store.go Outdated

olamilekan000 force-pushed the add-redis-storage-for-backend branch from c665d0d to 1f86a76 Compare March 4, 2026 14:49

olamilekan000 requested a review from mjudeikis March 4, 2026 14:50

olamilekan000 force-pushed the add-redis-storage-for-backend branch from 1f86a76 to 771dc90 Compare March 4, 2026 14:52

mjudeikis reviewed Mar 9, 2026

View reviewed changes

Comment thread backend/session/redis/redis.go Outdated

mjudeikis reviewed Mar 9, 2026

View reviewed changes

Comment thread backend/session/memory/memory.go

mjudeikis reviewed Mar 9, 2026

View reviewed changes

Comment thread deploy/charts/backend/values.yaml Outdated

mjudeikis reviewed Mar 9, 2026

View reviewed changes

olamilekan000 force-pushed the add-redis-storage-for-backend branch 2 times, most recently from 5343e9f to 2be882f Compare March 9, 2026 16:15

olamilekan000 requested a review from mjudeikis March 9, 2026 16:16

olamilekan000 force-pushed the add-redis-storage-for-backend branch 2 times, most recently from 581404f to d761aa6 Compare March 10, 2026 02:53